mahara-contributors team mailing list archive

[Mahara Bot <2009760@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/13861
Committed: https://git.mahara.org/mahara/mahara/commit/35e7926fe0f55ae435742de6e6836f5fcac1ac33
Submitter: "Doris Tam <doristam@xxxxxxxxxxxxxxx>"
Branch:    main

commit 35e7926fe0f55ae435742de6e6836f5fcac1ac33
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Mar 9 12:22:52 2023 +1300

Bug 2009760: Fixing issue with ORDER BY in multirecipient code

Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Change-Id: I3bbde780780887ca76a579a5c1e31f91661f27fc

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2009760

Title:
  Issue with deleting multirecipient notifications in MySQL

Status in Mahara:
  Fix Committed

Bug description:
  When deleting a person one of the cleanup things that happens is any
  multi-recipient notifications for the person are delete also. But when
  using MySQL it could cause an issue (segmentation fault) when deleting
  then via the admin/cli/delete_inactive_users.php CLI script.

  The cause of this was the SQL for creating one of the queries was
  wrong.

  The query ordering syntax was ' ORDER BY ? ' but we can't pass in the
  value that way because ADODB will wrap it in quotations and cause
  things to fail.

  We need to have the query be like this ' ORDER BY ' . $sortby  
  so that ADODB doesn't try to quote it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2009760/+subscriptions