mahara-contributors team mailing list archive

[Mahara Bot <1987709@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/13882
Committed: https://git.mahara.org/mahara/mahara/commit/0f9421dbf33d2d4a5ca57b8b53e5008594170c44
Submitter: "Doris Tam <doristam@xxxxxxxxxxxxxxx>"
Branch:    main

commit 0f9421dbf33d2d4a5ca57b8b53e5008594170c44
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Mar 29 16:04:16 2023 +1300

Bug 1987709: Allow setting of lastlastlogin to work as expected

The $USER->reanimate() function does the actual setting of the
lastlogin and lastlastlogin values

Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Change-Id: I05c226a5f2eb6e7b51cb9e26b8655a09a3a472cf

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1987709

Title:
  Authentication via SAML looks to cause improper setting of
  'lastlastlogin'

Status in Mahara:
  Fix Committed

Bug description:
  It looks like we set it in the auth/saml/lib.php file but also call
  the $USER->reanimate() function that then calls $USER->authenticate()
  that also look to set it.

  We need to check if we actually need to set it in the saml file or
  just leave it to the reanimate function

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1987709/+subscriptions