maria-developers team mailing list archive

[Sergey Petrunya <psergey@xxxxxxxxxxxx>]

At file:///home/psergey/dev/mysql-next/

------------------------------------------------------------
revno: 2816
revision-id: psergey@xxxxxxxxxxxx-20090706142603-z3z8ku4fdah6ntwv
parent: psergey@xxxxxxxxxxxx-20090706075739-ay9m392esf31wx0s
committer: Sergey Petrunya <psergey@xxxxxxxxxxxx>
branch nick: mysql-next
timestamp: Mon 2009-07-06 18:26:03 +0400
message:
  BUG#31480: Incorrect result for nested subquery when executed via semi join
  - Post-push valgrind fix
   
=== modified file 'sql/item_subselect.cc'
--- a/sql/item_subselect.cc	2009-07-06 07:57:39 +0000
+++ b/sql/item_subselect.cc	2009-07-06 14:26:03 +0000
@@ -289,8 +289,12 @@
   used_tables_cache &= ~OUTER_REF_TABLE_BIT;
   if (furthest_correlated_ancestor > 1)
     used_tables_cache |= OUTER_REF_TABLE_BIT;
-  const_item_cache &= test(!(used_tables_cache & 
-                           ~new_parent->join->const_table_map));
+
+  /* 
+    Don't update const_tables_cache yet as we don't yet know which of the
+    parent's tables are constant. Parent will call update_used_tables() anyway,
+    and that will be our chance to update.
+  */
 }