maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxx>]

Hi, knielsen!

On Aug 27, knielsen@xxxxxxxxxxxxxxx wrote:
>  2720 knielsen@xxxxxxxxxxxxxxx	2009-08-27
>       Fix parsing of invalid plugin enum option value.
>       
> === added file 'mysql-test/r/plugin_load2.result'
> --- a/mysql-test/r/plugin_load2.result	1970-01-01 00:00:00 +0000
> +++ b/mysql-test/r/plugin_load2.result	2009-08-27 09:42:25 +0000
> @@ -0,0 +1,2 @@
> +SELECT @@global.example_enum_var = 'e2';
> +ERROR HY000: Unknown system variable 'example_enum_var'
> 
> === added file 'mysql-test/t/plugin_load2-master.opt'
> --- a/mysql-test/t/plugin_load2-master.opt	1970-01-01 00:00:00 +0000
> +++ b/mysql-test/t/plugin_load2-master.opt	2009-08-27 09:42:25 +0000
> @@ -0,0 +1,3 @@
> +$EXAMPLE_PLUGIN_OPT
> +"--plugin-load=;EXAMPLE=ha_example.so;"
> +--loose-plugin-example-enum-var=nonexistientvalue
> 
> === added file 'mysql-test/t/plugin_load2.test'
> --- a/mysql-test/t/plugin_load2.test	1970-01-01 00:00:00 +0000
> +++ b/mysql-test/t/plugin_load2.test	2009-08-27 09:42:25 +0000
> @@ -0,0 +1,12 @@
> +--source include/have_example_plugin.inc
> +
> +# Test for bug in parsing plugin enum option.
> +# The bug was that the error from parsing a non-existent value was not properly
> +# handled, so the variable was assigned some arbitrary wrong value.
> +#
> +# We test this by passing --loose-plugin-example-enum-var=nonexistientvalue in
> +# the .opt file of the test case, and check that the variable is not wrongly
> +# set to a value in this case.
> +
> +--error 1193
> +SELECT @@global.example_enum_var = 'e2';

eh, I'm sorry, but do you check your .result files before committing ?
:)
 
Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@xxxxxxx>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring