← Back to team overview

maria-developers team mailing list archive

Re: bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (monty:2770)


Hi, Michael!

On Nov 29, Michael Widenius wrote:
>  2770 Michael Widenius	2009-11-30
>       Change type for functions in plugin.h:str_mysql_ftparser_param()
>       to const unsigned char and string lengths to size_t.

You cannot do it that way.
char -> const unsigned char is fine, but
int -> size_t is not, because they may have different width and on this
system your change breaks the ABI.

The best solution would be to undo your change and to keep internal
MariaDB problems (like gcc warnins in the MariaDB code) strictly
internal and not reflected in the API. But if you absolutely must to
change it - you have to increase the API version. It's an incompatible
change, you have to set it to 0x0200 thus making all existent ftparser
plugins invalid. And this will fork the API - when Sun/MySQL will change
the API and set the version to 0x0200, there will be two different
incompatible APIs both having 0x0200 version.

So, again, the best solution is to keep the int type.

Regards / Mit vielen Grüßen,

   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@xxxxxxx>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring

Follow ups