← Back to team overview

maria-developers team mailing list archive

Re: Patch for Windows problem with setting TZ


Sergei Golubchik <sergii@xxxxxxxxx> writes:

>> Alex Budovski has done some work to debug why some tests (binlog tests in
>> particular) are failing on Windows, and found that this is because
>> mysql-test-run.pl set the TZ variable. This interacts poorly with the Windows
>> Operating System.
>> It's actually only a few test cases that need to set TZ. Here is a quick patch
>> that avoids the need to set TZ except for tests that specifically requests it
>> (with the already existing --timezone=XXX mechanism in -master.opt).
>> Opinions?
> Why we didn't have this problem with MySQL in pushbuild ? 

Yeah, that's what I asked myself as well?

I remember that for long we did not run replication tests on Windows (because
they had tons of failures), maybe binlog tests also. But I kind of thought
that was fixed some time ago, don't remember for sure though.

Or maybe the Pushbuild Windows hosts were set to the +03:00 time zone.

Can't think of any better reason atm.

 - Kristian.

Follow ups