← Back to team overview

maria-developers team mailing list archive

bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (monty:2830) Bug#534626

 

#At lp:maria based on revid:monty@xxxxxxxxxxxx-20100310135540-mm65on3y6vktzpoy

 2830 Michael Widenius	2010-03-10
      Fix for Bug #534626 MyISAM table created in MariaDB not readable by MySQL
      modified:
        storage/myisam/mi_create.c

per-file messages:
  storage/myisam/mi_create.c
    Don't set HA_OPTION_NULL_FIELDS if table is not using CHECKSUM as this makes the table incompatible with MySQL.
=== modified file 'storage/myisam/mi_create.c'
--- a/storage/myisam/mi_create.c	2010-01-14 16:51:00 +0000
+++ b/storage/myisam/mi_create.c	2010-03-10 19:00:34 +0000
@@ -175,6 +175,13 @@ int mi_create(const char *name,uint keys
     }
   }
 
+  /*
+    Don't set HA_OPTION_NULL_FIELDS if no checksums, as this flag makes
+    that file incompatible with MySQL.  This is ok, as this flag is only
+    used if one specifics table level checksums.
+  */
+  if (!(options & HA_OPTION_CHECKSUM))
+    options&= ~HA_OPTION_NULL_FIELDS;
   if (packed || (flags & HA_PACK_RECORD))
     options|=HA_OPTION_PACK_RECORD;	/* Must use packed records */
   /* We can't use checksum with static length rows */