← Back to team overview

maria-developers team mailing list archive

Re: Help with memory leak in optimiser code

 

Hi!

21 марта 2010, в 20:45, Michael Widenius написал(а):

[skip]

Sergey>     subselect_single_select_engine::prepare().
Sergey> === modified file 'sql/item_subselect.cc'
Sergey> --- a/sql/item_subselect.cc	2010-03-09 15:03:54 +0000
Sergey> +++ b/sql/item_subselect.cc	2010-03-09 18:53:56 +0000
Sergey> @@ -1776,6 +1776,10 @@
Sergey>  {
Sergey>    if (prepared)
Sergey>      return 0;
Sergey> +  if (select_lex->join)
Sergey> +  {
Sergey> +    select_lex->cleanup();
Sergey> +  }
Sergey>    join= new JOIN(thd, select_lex->item_list,
Sergey>  		 select_lex->options | SELECT_NO_UNLOCK, result);
Sergey>    if (!join || !result)

Sanja, as you know the code, could you please verify the above bug
fix?

On first look it is not correct, cleunup() should be called before. But I'll check it in details.

References