maria-developers team mailing list archive
Mailing list archive
Re: bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (monty:2825)
>>>>> "Kristian" == Kristian Nielsen <knielsen@xxxxxxxxxxxxxxx> writes:
Kristian> Michael Widenius <monty@xxxxxxxxxxxx> writes:
>> === modified file 'storage/maria/ma_search.c'
>> --- a/storage/maria/ma_search.c 2009-05-06 12:03:24 +0000
>> +++ b/storage/maria/ma_search.c 2010-03-09 19:22:24 +0000
>> + info->int_keypos= info->keyread_buff + (ulonglong) info->int_keypos;
>> + info->int_maxpos= info->keyread_buff + (ulonglong) info->int_maxpos;
Kristian> We now get new compiler warnings about this:
Kristian> ma_search.c:79: warning: cast from pointer to integer of different size
Kristian> ma_search.c:80: warning: cast from pointer to integer of different size
Kristian> Not sure how to fix this ...
Kristian> (If you want my advice, the better way would be not to do this at all. You're
Kristian> actually adding two pointers here?!? Seems confusing, not to mention in
Kristian> voilation of the C standard. There's probably a better way; not sure why you
Kristian> did this, but eg. use a union if you want to store the value in the same
I fixed this by adding two more variables; No big deal for memory
usage in this case.