← Back to team overview

maria-developers team mailing list archive

Re: Review of 5.2 pluggable-auth tree

 

29.03.2010 09:53, Sergei Golubchik пишет:
> Hi, Oleksandr!
>
> On Mar 29, Oleksandr Byelkin wrote:
>   
>> [skip]
>>     
>>>>> + #ifdef _WIN32
>>>>>           
>>>> In the rest of my_global.h we use __WIN__
>>>> Wouldn't it be better to use the same constant everywhere?
>>>>         
>>> Yes, it would. And this constant should be _WIN32, __WIN__ was
>>> historically used, but it's incorrect - as was explained by our windows
>>> developers. I've just used the "recommended" symbol.
>>>       
>> If we both was confused by this maybe it has sense t put comment here...
>>     
> where ? every time _WIN32 is used ?
>
> No need to be confused, see for example
> http://predef.sourceforge.net/preos.html#sec24
> or
> http://msdn.microsoft.com/en-us/library/b0084kay%28VS.80%29.aspx
>   
in other cases difference between win32/64 is not so important IMHO, so
here comment would be good.



References