maria-developers team mailing list archive

Thread
Date

Re: [Branch ~maria-captains/maria/5.1] Rev 2988: Fix LP Bug#686184 - merge_debug test fails.

To: Vladislav Vaintroub <wlad@xxxxxxxxxxxxxxxx>, maria-developers@xxxxxxxxxxxxxxxxxxx
From: Oleksandr Byelkin <sanja@xxxxxxxxxxxx>
Date: Tue, 07 Dec 2010 08:31:49 +0200
In-reply-to: <20101206231543.8823.11443.launchpad@loganberry.canonical.com>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6

Hi!

On 07.12.2010 01:15, noreply@xxxxxxxxxxxxx wrote:

------------------------------------------------------------
revno: 2988
fixes bug(s): https://launchpad.net/bugs/686184
committer: Vladislav Vaintroub<wlad@xxxxxxxxxxxxxxxx>
branch nick: 5.1
timestamp: Mon 2010-12-06 22:34:50 +0100
message:
   Fix LP Bug#686184 - merge_debug test fails.
   The reason for failure is that DBUG_EXECUTE_IF in mi_open()
   only worked for Unix-formatted file names, due to strstr(name, "/crashed")

   The fix change strstr() above to strstr(name, "crashed"), to it can work with
   Windows file names as well.
modified:
   storage/myisam/mi_open.c

(M)Aria engine also has code like you fixed above in ma_open.c:

    DBUG_EXECUTE_IF("maria_pretend_crashed_table_on_open",
                    if (strstr(name, "/t1"))
                    {
                      my_errno= HA_ERR_CRASHED;
                      goto err;
                    });

Should it be also fixed?