maria-developers team mailing list archive

[Oleg Tsarev <oleg.tsarev@xxxxxxxxxxx>]

Kristian,

I review your changes and agree, thank you very much.
Now I want include with patch to Percona-Server (rnt-branch).
How can I respect licence questions?
Simle add COPYING.patch.name file?
Something more?

Best regards, Oleg

2011/1/4 Kristian Nielsen <knielsen@xxxxxxxxxxxxxxx>:
> Michael Widenius <monty@xxxxxxxxxxxx> writes:
>
>>>>>>> "Kristian" == Kristian Nielsen <knielsen@xxxxxxxxxxxxxxx> writes:
>>
>> <cut>
>>
>> Kristian> Anyway, I fixed the patch, added test cases, and merged into MariaDB. It is
>> Kristian> pushed here:
>>
>> Kristian>     lp:~knielsen/maria/5.2-percona-row_based_replication_without_primary_key
>>
>> Kristian> Here is the commit message:
>>
>> Kristian>   Merge Percona patch row_based_replication_without_primary_key.patch into MariaDB.
>>
>> Kristian>   This patch improves the selection of index to use to apply row-based
>> Kristian>   DELETE and UPDATE events on tables with no primary key (original code
>> Kristian>   picks the first index unconditionally).
>> Kristian>   If ANALYZE TABLE is done, the index cardinalities will be compared and
>> Kristian>   the best index will be used.
>>
>> Kristian>   Fixes some problems in the original patch:
>>
>> Kristian>    - Without ANALYZE TABLE, rec_per_key statistics is not available; in this
>> Kristian>      case the original patch could choose a really bad index, even ignoring
>> Kristian>      a primary key.
>>
>> Kristian>    - The original patch did not consider multi-column keys correctly, and
>> Kristian>      could thus pick a less desirable single-column key over a good
>> Kristian>      multi-column index.
>>
>> Kristian>   Also fixes Bug#58997, and adds test cases.
>>
>> Kristian> Monty, how do I include it in our percona tree?, can I just push here:
>>
>> Kristian>     lp:~maria-captains/maria/5.2-percona
>>
>> Yes, feel free to push if no one from Percona has any problems with
>> your patch.
>
> So, any objections or comments from Percona on this patch?
>
> I've included the patch below for convenience.
>
>  - Kristian.
>
>



-- 
Oleg Tsarev, Software Engineer, Percona Inc.