Thread Previous • Date Previous • Date Next • Thread Next |
Hi! On 14.01.2011 18:30, Michael Widenius wrote: [skip]
@@ -225,7 +229,7 @@ my_bool Expression_cache_tmptable::put_v DBUG_ENTER("Expression_cache_tmptable::put_value"); DBUG_ASSERT(inited); - if (!cache_table) + if (!cache_table || frozen) { Is it not eonugh to test for 'frozen'? (You should set frozen to 0 if cache_table is not set)
It will lead to complex enough code with double assignmend of cache_table and frozen, also it will lead to possible errors if code will be changed somewhere by other programmer.
[skip]
=== modified file 'sql/sql_expression_cache.h' <cut> @@ -50,6 +50,8 @@ class Item_field; class Expression_cache_tmptable :public Expression_cache { + ulong hit, miss; + bool frozen; ulong -> ulonglong (in a join you can have a LOT of row combinations)
But we use ulong for all global variables (I checked before using ulong). [skip]
Thread Previous • Date Previous • Date Next • Thread Next |