maria-developers team mailing list archive
Mailing list archive
Re: [Commits] Rev 2908: Fixed LP bugs #717577, #724942. in file:///home/igor/maria/maria-5.3-bug717577/
On Sun, Apr 24, 2011 at 03:08:12AM +0400, Sergey Petrunya wrote:
> Hello Igor,
> First, an overall comment: there are lots of typos/coding style violations in
> the patch. To reduce amount of effort spent on such things, I was just fixing
> them as I saw them and I'm attaching the patch with all the fixes (i.e. this
> patch should be applied on top of the patch that I was reviewing).
Now really with attached file.
Sergey Petrunia, Software Developer
Monty Program AB, http://askmonty.org
diff -ur /home/psergey/dev2/5.3-review-717577-clean/sql/item.cc 5.3-review-717577-comments/sql/item.cc
--- /home/psergey/dev2/5.3-review-717577-clean/sql/item.cc 2011-04-24 00:43:19.000000000 +0400
+++ 5.3-review-717577-comments/sql/item.cc 2011-04-24 00:10:10.000000000 +0400
@@ -4669,7 +4669,7 @@
- Check whether a field item can be substituted b an equal item
+ Check whether a field item can be substituted by an equal item
The function checks whether a substitution of a field item for
@@ -7264,7 +7264,7 @@
- Check whether a reference to field item can be substituted b an equal item
+ Check whether a reference to field item can be substituted by an equal item
The function checks whether a substitution of a reference to field item for
diff -ur /home/psergey/dev2/5.3-review-717577-clean/sql/item_cmpfunc.cc 5.3-review-717577-comments/sql/item_cmpfunc.cc
--- /home/psergey/dev2/5.3-review-717577-clean/sql/item_cmpfunc.cc 2011-04-24 00:43:19.000000000 +0400
+++ 5.3-review-717577-comments/sql/item_cmpfunc.cc 2011-04-24 00:10:07.000000000 +0400
@@ -5535,7 +5535,7 @@
The constructor builds a new item equal object for the equality f1=f2.
- One if the equal items can be constant. If this is the case it is passed
+ One of the equal items can be constant. If this is the case it is passed
always as the first parameter and the parameter with_const_item serves
as an indicator of this case.
Currently any non-constant parameter items must refer to an item of the
@@ -5590,12 +5590,11 @@
(this parameter is optional)
- The method adds the constant item c to the list equal_items. If the list
- hasn't not contained any constant item yet the item c is just added
- to the very beginning of the list. Otherwise the value of c is compared
- with the value of the constant item from equal_items. If they are not
- equal cond_false is set to TRUE. This serves as an indicator that this
- Item_equal is always FALSE.
+ The method adds the constant item c to the equal_items list. If the list
+ doesn't yet have any constant item, the item c is put into the front of
+ the list. Otherwise the value of c is compared with the value of the
+ constant item from equal_items. If they are not equal cond_false is set
+ to TRUE. This serves as an indicator that this Item_equal is always FALSE.
The optional parameter f is used to adjust the flag compare_as_dates.
@@ -5636,7 +5635,7 @@
@param field field whose occurrence is to be checked
- The function checks whether field is reffered to by one of the
+ The function checks whether field is referred to by one of the
items from the equal_items list.
diff -ur /home/psergey/dev2/5.3-review-717577-clean/sql/item_cmpfunc.h 5.3-review-717577-comments/sql/item_cmpfunc.h
--- /home/psergey/dev2/5.3-review-717577-clean/sql/item_cmpfunc.h 2011-04-24 00:43:19.000000000 +0400
+++ 5.3-review-717577-comments/sql/item_cmpfunc.h 2011-04-24 00:09:32.000000000 +0400
@@ -1630,7 +1630,7 @@
over all items from the list of the Item_field/Item_direct_view_ref classes.
TRUE <-> one of the items is a const item.
Such item is always first in in the equal_items list
@@ -1643,17 +1643,17 @@
This initially is set to FALSE. It becomes TRUE when this item is evaluated
as being always false. If the flag is TRUE the contents of the list
- the equal_items should be ignored.
+ the equal_items should be ignored.
compare_as_dates=TRUE <-> constants equal to fields from equal_items
- must be compared as datetimesnot as strings.
+ must be compared as datetimes and not as strings.
compare_as_dates can be TRUE only if with_const=TRUE
- The comomparator used to compare constants equal to fields from equal_items
+ The comparator used to compare constants equal to fields from equal_items
as datetimes. The comparator is used only if compare_as_dates=TRUE