← Back to team overview

maria-developers team mailing list archive

Re: [Commits] Rev 2983: MWL#89 - Automatic merge with 5.3 in file:///home/tsk/mprog/src/5.3-mwl89-merge/


Hi Timour,

On Mon, May 23, 2011 at 12:10:44PM +0300, Timour Katchaounov wrote:
> Thank you for the review, you manged to spot a couple of real omissions/
> problems with the implementation. I implemented or responded to all your
> review suggestions except two. The two ones that I didn't implement are
> marked with 'timour-todo'. All remaining replies are marked with 'timour:'.
> We already discussed the two issues I didn't address this time. They
> are not critical, but are time-consuming. I will add them to my todo for
> the task to complete after completing the regression test.
> The patch that addresses your review was merged with the latest 5.3 and
> pushed into 5.3-mwl89. If you have no objections, I'd like to push to 5.3
> ASAP. Specifically, please look at my change to sort_and_filter_keyuse().

Looked. I have no objections to pushing this into 5.3-main.

Sergey Petrunia, Software Developer
Monty Program AB, http://askmonty.org
Blog: http://s.petrunia.net/blog