← Back to team overview

maria-developers team mailing list archive

Re: Buildbot failure in filesort.cc:make_sortkey


Hi, Sergey!

It looks safe.
If it's urgent, can you fix it please? (wrap in UNINIT_VAR)
If not - I'll do when I merge a set of bugfixes from 5.1.

On Jun 02, Sergey Petrunya wrote:
> Current 5.3 fails as follows:
> http://buildbot.askmonty.org/buildbot/builders/mac-mini-x86-dbg/builds/771/steps/compile/logs/stdio
> g++ -DMYSQL_SERVER -DDEFAULT_MYSQL_HOME='"/usr/local/mysql"'
> -DMYSQL_DATADIR='"/usr/local/mysql/var"'
> -DSHAREDIR='"/usr/local/mysql/share/mysql"'
> -DPLUGINDIR='"/usr/local/mysql/lib/mysql/plugin"' -DHAVE_EVENT_SCHEDULER
> -DHAVE_CONFIG_H -I. -I../include -I../include -I../include -I../regex -I.
> -I../extra/libevent   -Wall -Wextra -Wunused -Wwrite-strings
> -Wno-strict-aliasing -Werror -DFORCE_INIT_OF_VARS -Wno-unused-parameter -g
> -Wall -Wextra -Wunused -Wwrite-strings -Wno-uninitialized -Wno-unused-parameter
> -Wnon-virtual-dtor -felide-constructors -fno-exceptions -fno-rtti -mtune=native
> -gdwarf-2 -O2 -Wuninitialized -DFORCE_INIT_OF_VARS    -fno-implicit-templates
> -fno-exceptions -fno-rtti -D_P1003_1B_VISIBLE -DSIGNAL_WITH_VIO_CLOSE
> .deps/debug_sync.Tpo -c -o debug_sync.o debug_sync.cc
> cc1plus: warnings being treated as errors
> filesort.cc: In function 'void make_sortkey(SORTPARAM*, uchar*, uchar*)':
> filesort.cc:878: warning: 'value' may be used uninitialized in this function
> make[3]: *** [filesort.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> It is not apparent for me whether this is a real error or not, bazaar history 
> shows that the failure is in your code of MWL#173. Could you please take a
> look?