← Back to team overview

maria-developers team mailing list archive

Re: [Commits] Rev 2955: Fix compiling on Windows. in file:///H:/bzr/mwl192/


> -----Original Message-----
> From: Vladislav Vaintroub [mailto:wlad@xxxxxxxxxxxxxxxx]
> Sent: Mittwoch, 6. Juli 2011 12:16
> To: 'Kristian Nielsen'; 'maria-developers@xxxxxxxxxxxxxxxxxxx'
> Subject: RE: [Commits] Rev 2955: Fix compiling on Windows. in
> file:///H:/bzr/mwl192/

> > > -extern uint find_type_or_exit(const char *x, TYPELIB *typelib,
> > > +extern unsigned int find_type_or_exit(const char *x, TYPELIB
> > >                                const char *option);
> > >  extern int find_type(char *x, const TYPELIB *typelib, unsigned int
> > full_name);
> > >  extern void make_type(char *to,unsigned int nr,TYPELIB *typelib);
> >
> > I do not understand what this patch has to do with my MWL#192 changes,
> > can you
> > help explain? (Again, I think the change is correct, I just would like
> > understand what I did to make this change necessary).
> Typelib.h is included by mysql.h.  There is no uchar on Windows, which
> makes source file not compile, if my_global.h not included (e.g only
> is used) .  In the last years, I keep fixing "uchar"  in public headers in
> versions of MySQL,  but it still pops up here and there again.

Hmm, err, I fixed "uint" and described that as "uchar". But all the same,
both uints and uchars have tendencies to creep into public headers, so I'm
fixing either when I come across them.