← Back to team overview

maria-developers team mailing list archive

Re: [Commits] Rev 3096: Alternate version of MySQL's fix for BUG#49453. in file:///home/psergey/dev2/5.3-push6/



This is not a review, just a quick look at the patch.
The below solution is totally cryptic. Please add a
comment why items in the ref_array are the right ones.

If someone ever has to deal with this code, even your
commit comment (not speaking that there is no code comment)
will provide absolutely no clue why items should be taken
from the ref-array.