maria-developers team mailing list archive

["Vladislav Vaintroub" <wlad@xxxxxxxxxxxxxxxx>]

> -----Original Message-----
> From: maria-developers-
> bounces+wlad=montyprogram.com@xxxxxxxxxxxxxxxxxxx [mailto:maria-
> developers-bounces+wlad=montyprogram.com@xxxxxxxxxxxxxxxxxxx] On
> Behalf Of Sergei Golubchik
> Sent: Samstag, 16. Juli 2011 16:52
> To: holyfoot@xxxxxxxxxxxx
> Cc: maria-developers@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Maria-developers] WL#177 add server-side error logging
> 

Hi Serg and HF,


> > +MYSQL_ADD_PLUGIN(sql_errlog sql_errlog.c
> > +  MODULE_ONLY MODULE_OUTPUT_NAME "sql_erlg")
> 
> why non-default module output name?
> 
> I think MODULE_OUTPUT_NAME should only be used when converting old
> plugins
> that have to keep non-default module name for compatibility reasons.

Correct. I was wondering about why MODULE_ONLY too in this case.  Is it bad
to optionally link this into the server statically? 

> new plugins don't need to use MODULE_OUTPUT_NAME at all.

MYSQL_ADD_PLUGIN(sql_errlog sql_errlog.c) should normally be just enough.