← Back to team overview

maria-developers team mailing list archive

Re: [Commits] Rev 3020: MWL#192: Non-blocking client API for libmysqlclient. in http://bazaar.launchpad.net/~maria-captains/maria/5.2


Hi Kristian,
It is my own perception, but I feel the code got severely obfuscated through
wrapper macros, and thus will be really hard to debug.  Myself, I'd prefer
it in a C/C++ source file, without macros (yes, it is means repetition, but
I would not expect the result to be much larger in terms of lines of code
with this).
Also, the macros I talk about define global  functions in a header file. At
least on Windows  it means linker error (multiple symbol definition) if the
header is included into 2 different C files.

> -----Original Message-----
> From: maria-developers-
> bounces+wlad=montyprogram.com@xxxxxxxxxxxxxxxxxxx [mailto:maria-
> developers-bounces+wlad=montyprogram.com@xxxxxxxxxxxxxxxxxxx] On
> Behalf Of Kristian Nielsen
> Sent: Dienstag, 20. September 2011 13:00
> To: maria-developers@xxxxxxxxxxxxxxxxxxx; Michael Widenius
> Subject: Re: [Maria-developers] [Commits] Rev 3020: MWL#192: Non-
> blocking client API for libmysqlclient. in
> captains/maria/5.2
> Hi Monty,
> Please find included the patch for MWL#192, non-blocking client API, for
> review.
> This patch is against MariaDB 5.2.8, though I expect the feature will
> eventually be merged and pushed to MariaDB 5.5.
> One thing in particular I would like to ask for advice on is if there are
> to improve the integration with libmysql/NET/Vio, as you know this code
> much
> better than me.
>  - Kristian.

Follow ups