← Back to team overview

maria-developers team mailing list archive

Re: [Commits] Rev 3100: Fix gcc 4.6 warnings about assigned but not used variables. in file:///home/bell/maria/bzr/work-maria-5.1-applebuild/

 

26.10.2011 22:18, Michael Widenius пишет:
[skip]

=== modified file 'storage/pbxt/src/thread_xt.cc'
--- a/storage/pbxt/src/thread_xt.cc	2010-09-28 13:05:45 +0000
+++ b/storage/pbxt/src/thread_xt.cc	2011-10-25 14:24:24 +0000
@@ -485,7 +485,8 @@ static void thr_free_resources(XTThreadP

  xtPublic void xt_bug(XTThreadPtr XT_UNUSED(self))
  {
-	static int *bug_ptr = NULL;
+	static int *bug_ptr __attribute__ ((unused));
+        bug_ptr= NULL;
  	
  	bug_ptr = NULL;
  }

No reason to set this to null twice.
Better to remove the variable altogether.

Th code was super strange before, I left it strange :) I think it is better to Percona to decide what to do with it (I sent them patch for 5.3).

[skip]


Follow ups

References