maria-developers team mailing list archive

Thread
Date

Re: [Commits] Rev 3241: Xtradb recently started to access thd members directly , e.g thd->stmt_da (ha_innodb.cc) in file:///H:/bzr/5.5/

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Kristian Nielsen <knielsen@xxxxxxxxxxxxxxx>
Date: Fri, 27 Jan 2012 11:53:21 +0100
In-reply-to: <20120126150636.AC4A0228649@mail.askmonty.org> (Vladislav Vaintroub's message of "Thu, 26 Jan 2012 15:06:36 +0000 (UTC)")
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)

Vladislav Vaintroub <wlad@xxxxxxxxxxxxxxxx> writes:

>   Xtradb  recently started to access thd members directly ,e.g thd->stmt_da (ha_innodb.cc)
>   It needs recompilation for embedded server, as layout of THD is different in embedded.

Did you consider instead fixing XtraDB to not access thd members directly?
Eg. using proper accessors, maybe adding new accessors if needed?
Or is this not possible for some reason?

It would be much preferable if XtraDB didn't mess with server internals like
this ...

 - Kristian.

Follow ups

Re: [Commits] Rev 3241: Xtradb recently started to access thd members directly , e.g thd->stmt_da (ha_innodb.cc) in file:///H:/bzr/5.5/
From: Vladislav Vaintroub, 2012-01-27