maria-developers team mailing list archive

Thread
Date

Re: [Commits] Rev 3434: MDEV-339, LP1001340 - system_time_zone is wrong on Windows in file:///H:/bzr/5.5/

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxxx>
Date: Fri, 15 Jun 2012 17:46:57 +0200
Cc: wlad@xxxxxxxxxxxx
In-reply-to: <20120615152223.1FA982C412A@mail.askmonty.org>
User-agent: Mutt/1.5.21 (2010-09-15)

Hi, Vladislav!

On Jun 15, Vladislav Vaintroub wrote:
> ------------------------------------------------------------
> revno: 3434
> revision-id: wlad@xxxxxxxxxxxxxxxx-20120615152106-p4a50d0yv2qj4fxk
> parent: wlad@xxxxxxxxxxxxxxxx-20120613093751-tv67fxuh1qcxm0by
> fixes bug: https://launchpad.net/bugs/1001340
> committer: Vladislav Vaintroub <wlad@xxxxxxxxxxxxxxxx>
> branch nick: 5.5
> timestamp: Fri 2012-06-15 17:21:06 +0200
> message:
>   MDEV-339, LP1001340 - system_time_zone is wrong on Windows
>   
>   On localized Windows versions, Windows uses localized time zone
>   names and contain non-ASCII characters.  non-ASCII characters appear
>   broken when displayed by clients
>   The fix is to declare system_time_zone variable to have UTF8
>   encoding and to convert tzname to UTF8.

Looks good, thanks!
Did you verify that it works?
(I vaguely remember that you don't have a localized Windows version)
Ok to push, if yes.

Regards,
Sergei