maria-developers team mailing list archive

Thread
Date

Re: [Commits] Rev 3453: MWL#182: Explain running statements

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxxx>
Date: Sat, 28 Jul 2012 10:15:41 +0200
In-reply-to: <20120717192704.6094063C855@pslp2>
User-agent: Mutt/1.5.21 (2010-09-15)

Hi, Sergey!

On Jul 17, Sergey Petrunya wrote:
> ------------------------------------------------------------
> revno: 3453
> revision-id: psergey@xxxxxxxxxxxx-20120717192703-bgt3xgkbs8qvz3tc
> parent: psergey@xxxxxxxxxxxx-20120717175208-ruovz91shg0ph875
> committer: Sergey Petrunya <psergey@xxxxxxxxxxxx>
> branch nick: 5.5-show-explain-r21
> timestamp: Tue 2012-07-17 23:27:03 +0400
> message:
>   MWL#182: Explain running statements
>   Address feedback from the second code review:
>   - Make SHOW EXPLAIN code convert the query string before pushing it as a warning text.   
> @@ -2135,8 +2135,35 @@ int fill_show_explain(THD *thd, TABLE_LI
>      }
>      else
>      {
> +      /*
> +        Push the query string as a warning. The query may be in a different
> +        charset than the charset that's used for error messages, so, convert it
> +        if needed.
> +      */

there's no test case for this. was it too difficult to create?

Regards,
Sergei