maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxxx>]

Hi, Alexey!

On Mar 29, Alexey Botchkov wrote:
> Hi, Sergei.
> 
> > remove your new opt_if_not_exists_ident rule, write it like
> > -          normal_key_type opt_ident key_alg '(' key_list ')'
> > +          normal_key_type opt_if_not_exists opt_ident key_alg '(' key_list ')'
> 
> I don't think it's a good idea. The 'opt_if_not_exists_ident' actually 
> has the body:
> opt_if_not_exists_ident:
>          opt_if_not_exists opt_ident
>          {
>            LEX *lex= Lex;
>            if (lex->check_exists && lex->sql_command != SQLCOM_ALTER_TABLE)
>            {
>              my_parse_error(ER(ER_SYNTAX_ERROR));
>              MYSQL_YYABORT;
>            }
>            $$= $2;
>          };
> 
> And i'd need to copy this everywhere instead of opt_**_ident call.

Right. Okay then, keep opt_if_not_exists_ident.

Regards,
Sergei