← Back to team overview

maria-developers team mailing list archive

Re: Fusion-io atomic writes patch comments


> -----Original Message-----
> From: Maria-developers [mailto:maria-developers-
> bounces+wlad=montyprogram.com@xxxxxxxxxxxxxxxxxxx] On Behalf Of
> Laurynas Biveinis
> Sent: Freitag, 24. Mai 2013 13:10
> To: maria-developers@xxxxxxxxxxxxxxxxxxx
> Subject: [Maria-developers] Fusion-io atomic writes patch comments
> Hi -
> We ported your patch to Percona Server, meanwhile we collected the
> following comments which perhaps are useful for you. These are
> addressed in our XtraDB port, so you will pick them up, but since you
> patched InnoDB as well, you might consider addressing them there as
> well. I tried to order them roughly in the order of importance.
> The comments below refer to rev 3720 of 5.5 tree (and one comment to
> MariaDB 10 trunk).

Thanks Laurynas. There are no testcases for atomic-writedness, it is not
easily unit-testable (and requires upper-class hardware in Buildbot instead
of working class VM:)
We ran sysbench manually, and some other tests, and that was it. I'm looking
forward to see  what you'll come up with.

Thanks for constructive hints. (Some of the comments seem non-issues, if you
ask me, __linux__ vs UNIV_LINUX, or setting errno, last error , etc) . That
Windows snippet was actually needed.

Thanks again,

> Regards,
> --
> Laurynas
> _______________________________________________
> Mailing list: https://launchpad.net/~maria-developers
> Post to     : maria-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~maria-developers
> More help   : https://help.launchpad.net/ListHelp

Follow ups