← Back to team overview

maria-developers team mailing list archive

Re: Review request: mdev-4634

 

Hi, Alexander!

Ok to push.

On Jun 26, Alexander Barkov wrote:
> === modified file 'mysql-test/r/type_date.result'
> --- mysql-test/r/type_date.result	2013-03-17 06:41:22 +0000
> +++ mysql-test/r/type_date.result	2013-06-26 11:14:20 +0000
> @@ -298,3 +298,14 @@ insert t1 values ('2010-10-10 15:foobar'
>  Warnings:
>  Warning	1265	Data truncated for column 'f1' at row 1
>  drop table t1;
> +#
> +# MDEV-4634 Crash in CONVERT_TZ
> +#
> +SELECT CONVERT_TZ(GREATEST(DATE('2021-00-00'),DATE('2022-00-00')),'+00:00','+7:5');

you could've put the test in include/type_hrtime.inc
and then you wouldn't need to duplucate it for all types.

But whatever, as you like.

> +CONVERT_TZ(GREATEST(DATE('2021-00-00'),DATE('2022-00-00')),'+00:00','+7:5')

Regards,
Sergei


References