← Back to team overview

maria-developers team mailing list archive

Re: Rev 3876: MDEV-4472 Audit-plugin. Server-related part of the task


04.09.2013 16:06, Sergei Golubchik wrote:
Hi, Alexey!

On Sep 04, Alexey Botchkov wrote:
03.09.2013 16:02, Sergei Golubchik wrote:
+  long long query_id;
should it rather be unsigned?
For the THD structure we have:
typedef int64 query_id_t;
So that it's originally unsigned.
You mean "originally signed". Yes, I know.
But I think that for API purposes we'd better make it unsigned.

Ok, the event->query_id is of 'unsigned long long' type now.

+  char *local_mysql_data_home;
+#ifdef _WIN32
+  local_mysql_data_home= (char *)GetProcAddress(0, "mysql_data_home");
+  local_mysql_data_home= mysql_data_home;
+#endif /*_WIN32*/
You shouldn't need it, file_logger.c is part of the server, not a
dynamically loaded plugin.
For now the plugin supposed to handle older Maria's and even MySQL.
So we have to include the file-logger code in there.
Yes. But this file is part of the server code, not part of the plugin.
The plugin is not even in the tree.

I removed the local_mysql_data_home. Just the declaration and the use of the mysql_data_home left.

Best regards.