← Back to team overview

maria-developers team mailing list archive

Re: MDEV-4956 - Reduce usage of LOCK_open: TABLE_SHARE::tdc.used_tables


Hi, Sergey!

On Aug 27, Sergey Vojtovich wrote:
> At lp:maria/10.0
> ------------------------------------------------------------
> revno: 3807
> revision-id: svoj@xxxxxxxxxxx-20130827121233-xh1uyhgfwbhedqyf
> parent: jplindst@xxxxxxxxxxx-20130823060357-pww92qxla7o8iir7
> committer: Sergey Vojtovich <svoj@xxxxxxxxxxx>
> branch nick: 10.0
> timestamp: Tue 2013-08-27 16:12:33 +0400
> message:
>   MDEV-4956 - Reduce usage of LOCK_open: TABLE_SHARE::tdc.used_tables
>   - tc_acquire_table and tc_release_table do not access
>     TABLE_SHARE::tdc.used_tables anymore
>   - in tc_acquire_table(): release LOCK_tdc after we relase LOCK_open
>     (saves a few CPU cycles in critical section)
>   - in tc_release_table(): if we reached table cache threshold, evict
>     to-be-released table without moving it to unused_tables. unused_tables
>     must be empty at this point (added assertion).

I don't understand what you're doing here, could you elaborate?
E.g. explain in a changeset comment what you've done, why you introduced
a new list for tables (all_share), what is its semantics, etc.


Follow ups