maria-developers team mailing list archive

Thread
Date

Re: [Commits] Rev 3942: MDEV-5205 - MariaDB does not start if more than 128 cpu's are available

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Wed, 6 Nov 2013 21:00:52 +0100
In-reply-to: <20131106185340.2AA6E2C4142@mail.askmonty.org>
User-agent: Mutt/1.5.22 (2013-10-16)

Hi, Sergey!

On Nov 06, Sergey Vojtovich wrote:
> ------------------------------------------------------------
> revno: 3942
> revision-id: svoj@xxxxxxxxxxx-20131106185339-wjz3xuru8ojnz00l
> parent: monty@xxxxxxxxxxxx-20131105183036-051tak9a2fq9ii05
> committer: Sergey Vojtovich <svoj@xxxxxxxxxxx>
> branch nick: 5.5-mdev5205
> timestamp: Wed 2013-11-06 22:53:39 +0400
> message:
>   MDEV-5205 - MariaDB does not start if more than 128 cpu's are available
>   
>   An addition to fix for MDEV-5205, fixes server crash on shutdown.
>   
>   Thread groups are destroyed asynchronously, that is kill server
>   thread sends shutdown request to all thread groups without waiting
>   for compeltion.
>   
>   It means all_groups array must not be freed until all thread groups
>   are down. This patch suggests that all_groups is freed when last
>   thread group is destroyed.

Looks reasonable.
ok to push

Regards,
Sergei