← Back to team overview

maria-developers team mailing list archive

Re: Malformed XML in mysql-test/std_data/Index.xml added in revision 3873

 

Jeremy,

On 11/26/2013 01:50 AM, Jeremy Cole wrote:
Bar,

Regarding your change:

http://bazaar.launchpad.net/~maria-captains/maria/10.0/revision/3873/mysql-test/std_data/Index.xml

I was wondering if it's intentional that mysql-test/std_data/Index.xml
now contains malformed XML. It wasn't mentioned in your commit message
and the test nor XML files do not mention it specifically.
Although utf8_5624_5_bad is supposed to be "bad" I didn't think it was
supposed to be *that* "bad" (mismatched "p" vs "a" tags):

Thanks for noticing this. It wasn't intentional. I fixed Index.xml.

Also, reported a bug. The XML parser should catch this kind of errors,
but it does not:

https://mariadb.atlassian.net/browse/MDEV-5338


I'm curious why you decided to check this file with xmllint :)


$ xmllint --noout mysql-test/std_data/Index.xml
mysql-test/std_data/Index.xml:126: parser error : Opening and ending tag
mismatch: p line 126 and a
       <reset>a-a4</reset><p>xxx04</a>
                                      ^
mysql-test/std_data/Index.xml:127: parser error : Opening and ending tag
mismatch: p line 127 and a
       <reset>a-aa5</reset><p>xxx05</a>
                                       ^
mysql-test/std_data/Index.xml:128: parser error : Opening and ending tag
mismatch: p line 128 and a
       <reset>a-aaa6</reset><p>xxx06</a>
                                        ^
mysql-test/std_data/Index.xml:129: parser error : Opening and ending tag
mismatch: p line 129 and a
       <reset>a-aaaa7</reset><p>xxx07</a>
                                         ^
mysql-test/std_data/Index.xml:130: parser error : Opening and ending tag
mismatch: p line 130 and a
       <reset>a-aaaaa8</reset><p>xxx08</a>
                                          ^
mysql-test/std_data/Index.xml:131: parser error : Opening and ending tag
mismatch: p line 131 and a
       <reset>a-aaaaaa9</reset><p>xxx09</a>
                                           ^
mysql-test/std_data/Index.xml:132: parser error : Opening and ending tag
mismatch: p line 132 and a
       <reset>a-aaaaaa10</reset><p>xxx10</a>
                                            ^
Regards,

Jeremy


_______________________________________________
Mailing list: https://launchpad.net/~maria-developers
Post to     : maria-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~maria-developers
More help   : https://help.launchpad.net/ListHelp



References