← Back to team overview

maria-developers team mailing list archive

Re: Build fail of MariaDB10 with TokuDB enabled

 

That's a good solution, but I'd still be wary of messing around too much with cmake's RPATH handling. I'll do this in ft-index soon though. 

Sent from my iPhone

> On Dec 3, 2013, at 4:09, Sergei Golubchik <serg@xxxxxxxxxxx> wrote:
> 
> Hi, Leif!
> 
>> On Dec 02, Leif Walsh wrote:
>> Yep, CMAKE_SKIP_BUILD_RPATH=0 would cause this exact problem. We
>> should add something to our cmake to warn if that is set to 0.
> 
> I'd suggest this change:
> 
> --- storage/tokudb/ft-index/ft/CMakeLists.txt   2013-11-19 14:35:31 +0000
> +++ storage/tokudb/ft-index/ft/CMakeLists.txt   2013-12-03 09:04:29 +0000
> @@ -11 +11 @@
> -target_link_libraries(logformat ${LIBTOKUPORTABILITY})
> +target_link_libraries(logformat ${LIBTOKUPORTABILITY}_static)
> 
> logformat is used internally during the build, it's not going to be
> installed. Thus it can use static libraries and avoid the whole rpath
> issue altogether.
> 
> This should probably be done for all binaries that are only used during
> the build.
> 
> Regards,
> Sergei
> 


References