maria-developers team mailing list archive

Thread
Date

Re: Rev 3914: MDEV-4956 - Reduce usage of LOCK_open: TABLE_SHARE::tdc.used_tables

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Thu, 12 Dec 2013 17:36:42 +0100
In-reply-to: <20131210150043.3DA3B2C415A@mail.askmonty.org>
User-agent: Mutt/1.5.22 (2013-10-16)

Hi, Sergey!

On Dec 10, Sergey Vojtovich wrote:
> At lp:maria/10.0
> 
> ------------------------------------------------------------
> revno: 3914
> revision-id: svoj@xxxxxxxxxxx-20131210150036-0hwh1gy4z3jalwsg
> parent: bar@xxxxxxxxxxxxxxx-20131203101253-mbz05d9jtkb3iycp
> committer: Sergey Vojtovich <svoj@xxxxxxxxxxx>
> branch nick: 10.0-mdev4956
> timestamp: Tue 2013-12-10 19:00:36 +0400
> message:
>   MDEV-4956 - Reduce usage of LOCK_open: TABLE_SHARE::tdc.used_tables
>   
>   - tc_acquire_table and tc_release_table do not access
>     TABLE_SHARE::tdc.used_tables anymore
>   - in tc_acquire_table(): release LOCK_tdc after we relase LOCK_open
>     (saves a few CPU cycles in critical section)
>   - in tc_release_table(): if we reached table cache threshold, evict
>     to-be-released table without moving it to unused_tables. unused_tables
>     must be empty at this point.

Looks ok to me

Regards,
Sergei