maria-developers team mailing list archive

Thread
Date

Re: MDEV-5364 mysql_upgrade should be more verbose

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Tue, 21 Jan 2014 15:49:04 +0100
In-reply-to: <20131215115939.811F22C4124@mail.askmonty.org>
User-agent: Mutt/1.5.22 (2013-10-16)

Hi, Holyfoot!

On Dec 15, holyfoot@xxxxxxxxxxxx wrote:
> At file:///home/hf/wmar/mdev-5364/
> 
> ------------------------------------------------------------
> revno: 4005
> revision-id: holyfoot@xxxxxxxxxxxx-20131215104419-ks2enrs2tds0z4ti
> parent: sergii@xxxxxxxxx-20131213120038-hjea4r5zp7sjuq8l
> committer: Alexey Botchkov <holyfoot@xxxxxxxxxxxx>
> branch nick: mdev-5364
> timestamp: Sun 2013-12-15 14:44:19 +0400
> message:
>   MDEV-5364 mysql_upgrade should be more verbose.
>           If the check_version_match() fails during the mysql_upgrade
>           execution, it doesn't print the 'mysql' output.
>           So the printing of the output added to the check_version_match()
>           and also to the get_upgrade_info_file_name() functions.

Looks ok, but I'd prefer to see a test case too.
Can you please add it?
Ok to push with a test case.

Regards,
Sergei