maria-developers team mailing list archive

Thread
Date

Re: MDEV-5419 no audit events for warnings converted to errors in the strict mode

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Tue, 21 Jan 2014 17:25:14 +0100
In-reply-to: <20131215124808.7954F2C4143@mail.askmonty.org>
User-agent: Mutt/1.5.22 (2013-10-16)

Hi, Holyfoot!

On Dec 15, holyfoot@xxxxxxxxxxxx wrote:
> revno: 4005
> revision-id: holyfoot@xxxxxxxxxxxx-20131215112825-1a5p7fa6mwdoin26
> parent: sergii@xxxxxxxxx-20131213120038-hjea4r5zp7sjuq8l
> committer: Alexey Botchkov <holyfoot@xxxxxxxxxxxx>
> branch nick: mdev-5419
> timestamp: Sun 2013-12-15 15:28:25 +0400
> message:
>   MDEV-5419 no audit events for warnings converted to errors in the strict mode.
>           Plugins get error notifications only when my_message_sql() is called.
>           But errors are launched with THD::raise_condition() calls in other
>           places. These are push_warning(), implementations of SIGNAL and
>           RESIGNAL commands.
>           So it makes sence to notify plugins there in THD::raise_condition().

Looks ok.
Please add test cases for MDEV-5419 and for MDEV-4846.
Then ok to push.

Regards,
Sergei