← Back to team overview

maria-developers team mailing list archive

Re: Review request for a fix for MDEV-5506

 

Hi, Alexander!

On Jan 28, Alexander Barkov wrote:
> 
> These types of bug are annoying. We've fixed a lot of them.
> I hoped to extend the new code gradually for non-static strings as well:
> 
> - to fix String::c_ptr*() not to use realloc if constructor knows that
>    the value is null terminated.
> - protect use of c_ptr*() is unsafe contexts.
> 
> and also put String::thread_specific into String::flags when
> merging to 10.0.
> 
> But this all can be done in 10.0 only. No need to do it in 5.3.

Agree!

> I will fix 5.3 simply to use make_empty_result().

Thanks!

Regards,
Sergei


References