maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Alexander!

On Jan 31, Alexander Barkov wrote:
> On 01/29/2014 06:22 PM, Sergei Golubchik wrote:
> > On Jan 29, Alexander Barkov wrote:
> >> I just tried to compile 10.0 on FreeBSD-9.1 RELEASE
> >> and noticed two problems:
> >>
> >> 1. It printed this warning for every source file:
> >>
> >> /usr/include/sys/timeb.h:42:2: warning: #warning "this file includes
> >> <sys/timeb.h> which is deprecated"
> >>
> >> This diff fixes the problem:
> >>
> >> -#ifdef HAVE_SYS_TIMEB_H
> >> +#if defined(HAVE_SYS_TIMEB_H) && !defined(__FreeBSD__)
> >
> > How comes? HAVE_SYS_TIMEB_H is only defined on Windows, there's no test
> > for <sys/timeb.h> anywhere in the cmake files.
> 
> Perhaps this line in config.h.cmake tests:
> 
> #cmakedefine HAVE_SYS_TIMEB_H 1
> 
> I guess it should be removed as well.

No-no, it's a template line. It will be either
#define HAVE_SYS_TIMEB_H 1 or #undef HAVE_SYS_TIMEB_H
in the resulting config.h file.

If you remove it, HAVE_SYS_TIMEB_H will never be in the config.h at all.

Regards,
Sergei