← Back to team overview

maria-developers team mailing list archive

Re: Proposal for: MDEV-5244: Make extended_keys=ON by default in 10.0


On 02/21/2014 04:14 PM, Sergey Petrunia wrote:
> Hello,
> I was looking at how to make extended_keys=ON by default in 10.0.
> There haven't been any bugs in the feature for quite some time, but we still
> have a question of how to be with the testsuite (do we run it with
> extended_keys=OFF, the old way, or with extended_keys=ON, the new way? both
> approaches have their advantages)
> So, I've just changed the default, and ran the default set of test suites.
> A total 12 tests fail, of those only 3 tests fail in the way that indicates
> that extended keys feature had an impact on the testcase (e.g. it got a
> different execution plan and probably no longer tests what it used to test).
> For these, I intend to place 
>   set opimizer_switch='extended_keys=off'
>   <testcase>
>   set opimizer_switch='extended_keys=on'
> around the affected testcases. The cases are:
> range_vs_index_merge_innodb - switch @@optimizer_switch (~3 testcases)
> index_merge_innodb - switch @@optimizer_switch (1 testcase)
> innodb.innodb_mysql -switch @@optimizer_switch (1 testcase)
> Any comments/input on this?

Sounds reasonable for me.

> BR
>  Sergei