← Back to team overview

maria-developers team mailing list archive

Re: MDEV-5081 - Simple performance improvement for MariaDB

 

Hi Sergei,

indeed, but that's only for -DBUILD_CONFIG=mysql_release or explicit
-DWITH_FAST_MUTEXES=ON. I though it should be enabled by
-DCMAKE_BUILD_TYPE=Release (the way I was attempting to get it).

Ok, I'll disable it in 5.5.

Thanks,
Sergey

On Fri, Feb 28, 2014 at 09:52:00AM +0100, Sergei Golubchik wrote:
> Hi, Sergey!
> 
> On Feb 27, Sergey Vojtovich wrote:
> > Hi Sergei,
> > 
> > do you know if we ship any binaries with fast mutex (-DMY_PTHREAD_FASTMUTEX)
> > enabled or officially suggest it? What was it's intention and what loads it was
> > supposed to make faster?
> 
> As far as I understand, we built with fastmutex on Linux.
> See cmake/build_configurations/mysql_release.cmake
> 
> > I'm trying to understand if fastmutex is worth fixing. It looks like
> > duplication of PTHREAD_MUTEX_ADAPTIVE_NP, so we have double spinning
> > when they're enabled.  According to my recent benchmarks it shown
> > worst performance.
> 
> Disable it then :)
> 
> Regards,
> Sergei
> 


Follow ups

References