maria-developers team mailing list archive

Thread
Date

Re: [Commits] Rev 3768: MDEV-5717: Server crash with insert statement containing DEFAULT into view

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Wed, 12 Mar 2014 12:18:20 +0100
Cc: sanja@xxxxxxxxxxx
In-reply-to: <20140312103418.07C97FE0D72@sanja.dnsalias.com>
User-agent: Mutt/1.5.22 (2013-10-16)

Hi, Sanja!

On Mar 12, sanja@xxxxxxxxxxxxxxxx wrote:
> revno: 3768
> revision-id: sanja@xxxxxxxxxxxxxxxx-20140312103416-3v6tan06crsqry28
> parent: sanja@xxxxxxxxxxxxxxxx-20140307115707-poaet8iwv9d55azm
> committer: sanja@xxxxxxxxxxxxxxxx
> branch nick: work-maria-5.3-MDEV-5717
> timestamp: Wed 2014-03-12 12:34:16 +0200
> message:
>   MDEV-5717: Server crash with insert statement containing DEFAULT into view
>   
>   Item_default_value::arg can be NULL so walk() should take it into consideration.

> === modified file 'sql/item.h'
> --- a/sql/item.h	2014-02-19 13:45:33 +0000
> +++ b/sql/item.h	2014-03-12 10:34:16 +0000
> @@ -3551,7 +3551,7 @@ public:
>  
>    bool walk(Item_processor processor, bool walk_subquery, uchar *args)
>    {
> -    return arg->walk(processor, walk_subquery, args) ||
> +    return (arg && arg->walk(processor, walk_subquery, args)) ||
>        (this->*processor)(args);
>    }

Ok to push.

But *please* install the diff_p bzr plugin as described here:
https://mariadb.com/kb/en/how-to-get-more-out-of-bzr-when-working-on-mariadb/#making-bzr-to-include-function-names-in-diffs

Regards,
Sergei