← Back to team overview

maria-developers team mailing list archive

Re: A fix for MDEV-5689 ExtractValue(xml, 'substring(/x, /y)') crashes


Hi, Alexander!

On Mar 23, Alexander Barkov wrote:
> >>> On Feb 20, Alexander Barkov wrote:
> >>>> please review a fix for MDEV-5689.
> >>>>
> >>>> It also fixes
> >>>> MDEV-5709 ExtractValue() with XPath variable references returns wrong
> >>>> result.
> I pushed my patch to 10.0.
> But the reported test case did not crash without the fix.
> I guess this is because some fix was earlier merged from
> MySQL to MariaDB-5.5 and then to MariaDB-10.0.

Yes, I've merged the fix from MySQL-5.5

> Should now a part of this MySQL fix be reverted in MariaDB-10.0?

As you like.
If I recall correctly, it marks Item_nodesets as always not const.
I don't see it causing any harm, these items are never part of the
item tree, so their non-const-ness cannot be propagated up and affect
other items and complex expression. But I could be missing something,