← Back to team overview

maria-developers team mailing list archive

Re: WebScaleSQL: Adjust linking flags to not embed some libs

 

Hi, Sergey!

On May 27, Sergey Vojtovich wrote:
> Hi Sergei,
> 
> during our recent discussion re WebScaleSQL patches we agreed to accept $subj:
> https://github.com/webscalesql/webscalesql-5.6/commit/361e3b83145402945b737dceae85f27e4cf3591c
> 
> I studied our binaries and it looks like we embed zlib and ssl libraries only
> if WITH_ZLIB=bundled/WITH_SSL=bundled. E.g. DEB/RPM packages use system libs
> and do not embed zlib/ssl, whereas tarball uses bundled zlib/yassl and embeds
> them.
> 
> Not embedding yassl into the client library will make the latter almost useless.
> Same probably applies to zlib even though it is normally offered by OS-es.
> 
> Said the above I believe our build scripts behave properly and we should skip
> this patch. What's your take?

Right, it seems to be MySQL-only patch. We don't even have this chunk in
ssl.cmake that this patch is removing.

Regards,
Sergei


References