← Back to team overview

maria-developers team mailing list archive

Re: [Commits] Rev 4259: MDEV-6120: When slave stops with error, error message should indicate the failing GTID in http://bazaar.launchpad.net/~maria-captains/maria/10.0

 

Sergey Vojtovich <svoj@xxxxxxxxxxx> writes:

>> +perl;
>> +  use strict;
>> +  use warnings;
>> +  my $log_error= $ENV{'LOG_ERROR'} or die "LOG_ERROR not set";
>> +  open(FILE, "<", "$log_error") or die("Unable to open $log_error: $!\n");

> Why didn't you like include/search_pattern_in_file.inc? It should perfectly able
> to match your patterns.

Ah, cool, I did not realise we had a facility for this, thanks for the
pointer!

I've pushed the patch with the inline perl replaced with calls to
include/search_pattern_in_file.inc.

Thanks for review!

 - Kristian.


References