maria-developers team mailing list archive

Thread
Date

Re: [JIRA] (MDEV-6336) NEED REVIEW: mysqldump --master-data does not work with GTID setups

To: "Michael Widenius \(JIRA\)" <jira@xxxxxxxxxxxxxxxxxxxxx>
From: Kristian Nielsen <knielsen@xxxxxxxxxxxxxxx>
Date: Wed, 09 Jul 2014 13:56:58 +0200
Cc: MariaDB Developers <maria-developers@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <JIRA.38523.1402574176000.444.1404838191209@Atlassian.JIRA> (Michael Widenius's message of "Tue, 8 Jul 2014 19:49:51 +0300 (EEST)")
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)

"Michael Widenius (JIRA)" <jira@xxxxxxxxxxxxxxxxxxxxx> writes:

> Here is the review:
>
> ------------------------------------------------------------
> revno: 4245
> revision-id: knielsen at knielsen-hq.org-20140616093803-gub60pda6t77ch3k
> committer: knielsen at knielsen-hq.org
> timestamp: Mon 2014-06-16 11:38:03 +0200
> message:
>   MDEV-6336: mysqldump --master-data does not work with GTID setups
>   MDEV-6344: mysqldump issues FLUSH TABLES, which gets written into binlog and replicated

Thanks for review Monty!

I fixed all of your suggestions.

 - Kristian.