maria-developers team mailing list archive

[Sergey Vojtovich <svoj@xxxxxxxxxxx>]

FYI: tests on little-endian Power8 fail too, but differently:
http://buildbot.askmonty.org/buildbot/builders/bintar-trusty-p8/builds/137/steps/test/logs/stdio

On Thu, Oct 09, 2014 at 02:09:21PM +0400, Sergey Vojtovich wrote:
> Hi Kouhei, Kentoku,
> 
> thanks for merging this fix. Test failures that I was talking about are now
> reproduced by buildbot:
> http://buildbot.askmonty.org/buildbot/builders/bintar-rhel6-p8-debug/builds/168/steps/test/logs/stdio
> 
> From this log I can guess it has something to do with endianness: Power8 is
> big-endian. If that's the case little-endian "bintar-trusty-p8-debug" should
> run these tests successfully (but this build isn't ready yet).
> 
> Is it something you will be interested fixing?
> 
> Regards,
> Sergey
> 
> On Thu, Oct 09, 2014 at 05:41:34PM +0900, Kouhei Sutou wrote:
> > Hi Sergey,
> > 
> > Thanks for the fix! I've merged your change into Groonga:
> > 
> >   https://github.com/groonga/groonga/commit/b3d38c5b9863cb7a9e93b9461c8b93fbfbfa79dc
> > 
> > Thanks,
> > --
> > kou
> > 
> > In <20141009083146.GA3231@june>
> >   "[Commits] [svoj@xxxxxxxxxxx: Rev 4437: Fixed mroonga build failure on Power8: define generic gcc version of in lp:maria/10.0]" on Thu, 9 Oct 2014 12:31:47 +0400,
> >   Sergey Vojtovich <svoj@xxxxxxxxxxx> wrote:
> > 
> > > Hi Kentoku,
> > > 
> > > FYI: I just pushed this fix to 10.0. There're also some test failures on Power8
> > > in mroonga/storage suite, mroonga/wrapper was 100% successful.
> > > 
> > > Regards,
> > > Sergey
> > > 
> > > ----- Forwarded message from Sergey Vojtovich <svoj@xxxxxxxxxxx> -----
> > > 
> > > Date: Thu,  9 Oct 2014 08:25:58 +0000 (UTC)
> > > From: Sergey Vojtovich <svoj@xxxxxxxxxxx>
> > > To: commits@xxxxxxxxxxx
> > > Subject: [Commits] Rev 4437: Fixed mroonga build failure on Power8: define generic gcc version of in lp:maria/10.0
> > > 
> > > At lp:maria/10.0
> > > 
> > > ------------------------------------------------------------
> > > revno: 4437
> > > revision-id: svoj@xxxxxxxxxxx-20141009082545-nt183b7y1gjihfjp
> > > parent: psergey@xxxxxxxxxxxx-20141006112922-45pcytb993xcwh89
> > > committer: Sergey Vojtovich <svoj@xxxxxxxxxxx>
> > > branch nick: 10.0-mroonga
> > > timestamp: Thu 2014-10-09 12:25:45 +0400
> > > message:
> > >   Fixed mroonga build failure on Power8: define generic gcc version of
> > >   GRN_SET_64BIT.
> > > === modified file 'storage/mroonga/vendor/groonga/lib/groonga_in.h'
> > > --- a/storage/mroonga/vendor/groonga/lib/groonga_in.h	2014-09-20 15:33:45 +0000
> > > +++ b/storage/mroonga/vendor/groonga/lib/groonga_in.h	2014-10-09 08:25:45 +0000
> > > @@ -505,6 +505,9 @@ typedef int grn_cond;
> > >  /* todo */
> > >  #  define GRN_SET_64BIT(p,v) \
> > >    (void)atomic_swap_64(p, v)
> > > +# elif defined(__ATOMIC_SEQ_CST) /* GCC atomic builtins */
> > > +#  define GRN_SET_64BIT(p,v) \
> > > +   __atomic_store_n(p, v, __ATOMIC_SEQ_CST)
> > >  # endif /* ATOMIC 64BIT SET */
> > >  
> > >  # ifdef HAVE_MKOSTEMP
> > > 
> > > _______________________________________________
> > > commits mailing list
> > > commits@xxxxxxxxxxx
> > > https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits
> > > 
> > > ----- End forwarded message -----
> > > _______________________________________________
> > > commits mailing list
> > > commits@xxxxxxxxxxx
> > > https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits
> > _______________________________________________
> > commits mailing list
> > commits@xxxxxxxxxxx
> > https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~maria-developers
> Post to     : maria-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~maria-developers
> More help   : https://help.launchpad.net/ListHelp