maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, James!

On Sep 06, James Briggs wrote:
> Hi List.
> 
> Below is my patch that implements the CREATE [[NO] FORCE] VIEW
> options against MariaDB 10.1.0.

Thanks!
But we need to know under what license this contribution is available.

See
https://mariadb.com/kb/en/mariadb-contributor-agreement-frequently-asked-questions/

We can only accept contributions under MCA (MariaDB Contributor
Agreement) or the New BSD (3-clause) license.

You can state that in the email, if you'd like

> Notes:
> 
> - It's a fairly solid patch, but I think the best thing is
> to commit it to alpha and let it bake for a while.
> 
> - it passes t/view.test:
> 
> # ./mysql-test-run.pl view
> Logging: ./mysql-test-run.pl  view
> vardir: /usr/local/mariadb-10.1.0/mysql-test/var
> MariaDB Version 10.1.0-MariaDB-debug
> 
> TEST                                      RESULT   TIME (ms) or COMMENT
> --------------------------------------------------------------------------
> main.view                                [ pass ]   1896
> --------------------------------------------------------------------------
> The servers were restarted 0 times
> Spent 1.896 of 7 seconds executing testcases
> Completed: All 1 tests were successful.
> 
> - I wrote tests/view.pl which does 8,000 tests. It passes.
> (I will include it in a separate email.)
> 
> - Please take a look at the style, and the 411 comments.

Regards,
Sergei