maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Nirbhay!

On Oct 23, nirbhay@xxxxxxxxxx wrote:
>
> Added 'mariadb-galera-server' metapackage to install all
> necessary Galera-related dependencies.
> 
> ---
>  debian/dist/Debian/control | 13 ++++++++++---
>  debian/dist/Ubuntu/control | 13 ++++++++++---
>  2 files changed, 20 insertions(+), 6 deletions(-)
> 
> diff --git a/debian/dist/Debian/control b/debian/dist/Debian/control
> index e68f027..bc48dbc 100644
> --- a/debian/dist/Debian/control
> +++ b/debian/dist/Debian/control
> @@ -194,9 +194,7 @@ Recommends: libhtml-template-perl
>  Pre-Depends: mariadb-common, adduser (>= 3.40), debconf
>  Depends: mariadb-client-10.1 (>= ${source:Version}), libdbi-perl,
>           perl (>= 5.6), ${shlibs:Depends}, ${misc:Depends}, psmisc, passwd,
> -         lsb-base (>= 3.0-10), mariadb-server-core-10.1 (>= ${binary:Version}),
> -         galera (>=25.2), rsync, lsof, socat | netcat, grep, gawk, iproute,
> -         coreutils, findutils
> +         lsb-base (>= 3.0-10), mariadb-server-core-10.1 (>= ${binary:Version})
>  Provides: mariadb-server, mysql-server, virtual-mysql-server
>  Conflicts: mariadb-server (<< ${source:Version}), mysql-server (<< ${source:Version}),
>      mysql-server-4.1, mysql-server-5.0, mysql-server-5.1, mysql-server-5.5,

Looks ok. Few comments:

1. What about RPM?
2. Did you compare with, say, non-galera 10.0 - just to make sure all
   dependencies you removed are, indeed, only for galera and the server
   doesn't need any of that?
3. I'd also add /etc/mysql/conf.d/galera.cnf (/etc/my.cnf.d/galera.cnf
   in rpms) that enables wsrep, and may be sets other reasonable defaults
   for galera.

Regards,
Sergei