maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Vicențiu!

On Jan 17, Vicențiu Ciorbaru wrote:
> 
> Here's the new diff, let me know if you have any more comments. Shall I
> push this as is?

Yes, just one small detail (file name and the comment), see below.
Then please push, no need to ask for another review :)

But...

1. Please don't paste patches into the email anymore.
   At least not with your mail client that wraps long lines around and
   sends everything as html.

   See https://mariadb.com/kb/en/using-git/#commit-emails

2. Why git? This is the patch for 10.0 bug, at the moment 10.0 is still
   in bzr.

3. This looks like a reverse diff, how did you manage to do that? :) 

> diff --git a/mysql-test/t/statistics_index_crash.test b/mysql-test/t/statistics_index_crash.test
> deleted file mode 100644
> index dbbdca3..0000000
> --- a/mysql-test/t/statistics_index_crash.test

if you create a new test file for one bug only (as opposite to adding to
an existing test file), mention the bug number in the file name. Like

statistics_index_crash-7362.test

> +++ /dev/null
> @@ -1,26 +0,0 @@
> ---source include/have_stat_tables.inc
> ---source include/have_innodb.inc

Start a test case for a bug with a comment that says the bug number,
the synopsys, and optionally more information, if needed. The bare
minimum looks like

#
# MDEV-7362 ANALYZE TABLES crash with table-independent-statistics gathering 
# MDEV-7380 engine-independent stats SEGV on ANALYZE TABLE (#2) 
#

> -
> -CREATE TABLE t1 (a longtext, FULLTEXT KEY (`a`)) ENGINE=InnoDB;
> -INSERT INTO t1 VALUES (unhex('3E0D0A4141414142334E7A6143317963324541414141424977414141674541726D'));
> -ANALYZE TABLE t1 PERSISTENT FOR ALL;
> ---sorted_result
> -SELECT * FROM mysql.index_stats WHERE index_name='a' AND table_name='t1';
> -DROP TABLE t1;
> -
> -CREATE TABLE t1 (a longtext, FULLTEXT KEY (`a`)) ENGINE=MyISAM;
> -INSERT INTO t1 VALUES (unhex('3E0D0A4141414142334E7A6143317963324541414141424977414141674541726D'));
> -ANALYZE TABLE t1 PERSISTENT FOR ALL;
> ---sorted_result
> -SELECT * FROM mysql.index_stats WHERE index_name='a' AND table_name='t1';
> -DROP TABLE t1;
> -
> -CREATE TABLE geom (g GEOMETRY NOT NULL, SPATIAL INDEX(g)) ENGINE=MyISAM;
> -INSERT INTO geom VALUES
> -    (MultiPolygonFromText('MULTIPOLYGON(((28 26,28 0,84 0,84 42,28 26),(52 18,66 23,73 9,48 6,52 18)),((59 18,67 18,67 13,59 13,59 18)))')),
> -    (MPolyFromText('MULTIPOLYGON(((28 26,28 0,84 0,84 42,28 26),(52 18,66 23,73 9,48 6,52 18)),((59 18,67 18,67 13,59 13,59 18)))')),
> -    (MPolyFromWKB(AsWKB(MultiPolygon(Polygon(LineString(Point(0, 3), Point(3, 3), Point(3, 0), Point(0, 3)))))));
> -ANALYZE TABLE geom PERSISTENT FOR ALL;
> ---sorted_result
> -SELECT * FROM mysql.index_stats WHERE index_name='g' AND table_name='geom';
> -DROP TABLE geom;

Regards,
Sergei