← Back to team overview

maria-developers team mailing list archive

Re: e91559c: MDEV-7006 MDEV-7007: SET STATEMENT and slow log


Hi, Sergei!

On 29.01.15 17:41, Sergei Golubchik wrote:
2. I didn't quite like that you've added restore_set_statement_var, reset_arena_for_set_stmt, free_arena_for_set_stmt, etc everywhere. I'd prefer you to add them to one function which is called from all these places. Like, there must be some cleanup-after-statement function that you should be able to use.

Could you explain what you mean above?

First my thought was that I use this methods together in several places and I have to make function out of it, but then I found that they used alone in most places and there is no repeatable sequence.