← Back to team overview

maria-developers team mailing list archive

Re: [MDEV-7586] Merged derived tables/VIEWs increment created_tmp_tables


On Sun, Feb 22, 2015 at 10:22:39AM +0200, Vicențiu Ciorbaru wrote:
> Hi Sergey!
> As discussed on the mdev page, I've implemented the fix for
> incrementing the created_tmp_tables variable.
> I've attached the patch for review. The changes in the patch are
> explained within the mdev page.
> commit 53d78644b793f7b667e71863ccd0b1ba54c894f3
> Author: Vicențiu Ciorbaru <cvicentiu@xxxxxxxxx>
> Date:   Sun Feb 22 03:40:17 2015 +0200
>     MDEV-7586: Merged derived tables/VIEWs increment created_tmp_tables
>     Temporary table count fix. The number of temporary tables was increased
>     when the table is not actually created. (when do_not_open was passed
>     as TRUE to create_tmp_table).
>     Another issue fixed is that create_tmp_table was called incorrectly
>     in create_result_table, having keep_row_order passed for the do_not_open
>     parameter and keep_row_order always set to false.

Confirm, the second issue should be fixed. Please make a fix for it in a
separate commit.

Sergei Petrunia, Software Developer
MariaDB Corporation | Skype: sergefp | Blog: http://s.petrunia.net/blog